Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: update to new digga api #300

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Conversation

Pacman99
Copy link
Member

No description provided.

@blaggacao
Copy link
Contributor

blaggacao commented May 31, 2021

Would you agree we should wait the flatten tree / dns implementation and probably also self.inputs instead of inputs?

@Pacman99
Copy link
Member Author

Would you agree we should wait the flatten tree / dns implementation and probably also self.inputs instead of inputs?

Agreed. Don't think this should be merged until digga 0.2.0 is pretty much ready.

@Pacman99 Pacman99 marked this pull request as draft May 31, 2021 03:21
Copy link
Contributor

@blaggacao blaggacao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agenix obersvation ...

};
};

devshell.externalModules = { pkgs, ... }: {
packages = [ pkgs.agenix ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to have the agenix command available in the devshell menu, we'd have to expose it as a commands = [ { } ];.

Not sure if that was the intention though, but it might be a good idea, regardless.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly wanted to avoid too much devshell related code in flake.nix. At some point I would like to add a devshell.toml in this repo, I just don't have anything to put in there other than agenix.

I would say to add the proper agenix command whenever a devshell.toml is added.

Copy link
Contributor

@blaggacao blaggacao May 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point I would like to add a devshell.toml in this repo

👍

@Pacman99 Pacman99 force-pushed the update-digga branch 2 times, most recently from 269d8a5 to 8d34f09 Compare June 1, 2021 01:59
@Pacman99 Pacman99 marked this pull request as ready for review June 1, 2021 01:59
@Pacman99
Copy link
Member Author

Pacman99 commented Jun 1, 2021

bors try

bors bot added a commit that referenced this pull request Jun 1, 2021
@bors
Copy link
Contributor

bors bot commented Jun 1, 2021

try

Build succeeded:

@Pacman99
Copy link
Member Author

Pacman99 commented Jun 1, 2021

bors try

bors bot added a commit that referenced this pull request Jun 1, 2021
@bors
Copy link
Contributor

bors bot commented Jun 1, 2021

try

Build succeeded:

@Pacman99 Pacman99 merged commit 7110767 into divnix:develop Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants